Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain/owasm: Add more unit tests and fix nil retdata and nil calldata #2148

Merged
merged 6 commits into from
Jul 5, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jul 4, 2020

Implementation details

  • Make go-owasm not panic if copy on empty span
  • Make resolve status failure if the script fails to call set_return_data
  • Remove redundant prepare error message
  • Add more unit tests

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@sorawit sorawit requested review from Benzbeeb and taobun July 4, 2020 16:20
@render
Copy link

render bot commented Jul 4, 2020

@sorawit sorawit changed the title chain/owasm: Add more unit tests and fix nil retdata chain/owasm: Add more unit tests and fix nil retdata and nil calldata Jul 5, 2020
@sorawit sorawit merged commit c04facb into master Jul 5, 2020
@sorawit sorawit deleted the owasm-test branch July 5, 2020 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants