Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Fixed the overflow-scroll interaction on mobile #2350

Merged
merged 3 commits into from
Jul 31, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Jul 31, 2020

Implementation details

  • Fixed the mobile scroll issue at the tab header on Tab Component

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach July 31, 2020 06:39
@render
Copy link

render bot commented Jul 31, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilpeach evilpeach merged commit 64eb6c4 into master Jul 31, 2020
@evilpeach evilpeach deleted the improve-mobile-version branch July 31, 2020 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants