Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Bridge & CacheBridge with relay multiple #2620

Merged
merged 8 commits into from
Sep 11, 2020
Merged

Bridge & CacheBridge with relay multiple #2620

merged 8 commits into from
Sep 11, 2020

Conversation

prin-r
Copy link
Member

@prin-r prin-r commented Sep 8, 2020 •
edited
Loading

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Sep 8, 2020

Your Render PR Server URL is https://d3n-scan-pr-2620.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-btbh0pipp1jnjj0v5790.

taobun
taobun suggested changes Sep 9, 2020
View reviewed changes
bridges/evm/contracts/CacheBridge.sol Outdated Show resolved Hide resolved
bridges/evm/contracts/ProxyBridge.sol Show resolved Hide resolved
@prin-r prin-r requested a review from taobun September 9, 2020 10:29
taobun
taobun suggested changes Sep 9, 2020
View reviewed changes
bridges/evm/contracts/CacheBridge.sol Outdated Show resolved Hide resolved
bridges/evm/contracts/IBridge.sol Outdated Show resolved Hide resolved
@prin-r prin-r requested a review from taobun September 10, 2020 07:27
taobun
taobun approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tansawit tansawit merged commit 09da233 into master Sep 11, 2020
@tansawit tansawit deleted the bridge-relay-multiple branch September 11, 2020 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taobun taobun taobun approved these changes

@tansawit tansawit Awaiting requested review from tansawit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prin-r @taobun @tansawit