Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Wire up proposal vote #2621

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Scan: Wire up proposal vote #2621

merged 6 commits into from
Sep 11, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Sep 8, 2020

Fixed: #2615

Implementation details

  • Wired up the data to proposal vote
    • Turnout rate on Proposal Homepage
    • Proposal Index page
      • Turnout rate on Turnout pie chart
      • VoteStat on result box.
  • Fixed some typo
  • Added optionInt to ID.re

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Sep 8, 2020

scan/src/pages/ProposalIndexPage.re Outdated Show resolved Hide resolved
scan/src/pages/ProposalIndexPage.re Outdated Show resolved Hide resolved
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check https://d3n-scan-pr-2621.onrender.com/proposal/25. Why the percentage of abstain choice is 0?

scan/src/subscriptions/VoteSub.re Outdated Show resolved Hide resolved
scan/src/subscriptions/VoteSub.re Outdated Show resolved Hide resolved
scan/src/subscriptions/VoteSub.re Outdated Show resolved Hide resolved
scan/src/subscriptions/VoteSub.re Show resolved Hide resolved
scan/src/subscriptions/VoteSub.re Show resolved Hide resolved
@pzshine pzshine merged commit a083efa into master Sep 11, 2020
@pzshine pzshine deleted the wire-up-proposal-vote branch September 11, 2020 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing proposal flow
2 participants