Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ledgerblue dependency #30

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

chrisCryptoCom
Copy link
Contributor

Ledgerblue 0.1.42 has an issue that leads to failing installs with newer setuptools versions.
See: LedgerHQ/blue-loader-python#104

This PR bumps the dependency and thereby resolves #29

@RogerKSI
Copy link
Contributor

Hi, @chrisCryptoCom, thanks for your contribution.

There's an issue with the poetry lock file in the test. I just updated the version.
Could you sync the branch and regenerate the lock file with poetry 1.4.1?

@chrisCryptoCom
Copy link
Contributor Author

chrisCryptoCom commented Mar 23, 2023

Hi, @chrisCryptoCom, thanks for your contribution.

There's an issue with the poetry lock file in the test. I just updated the version. Could you sync the branch and regenerate the lock file with poetry 1.4.1?

Sure thanks for the hint, this is the first time for me working with poetry😅
I merged in the master branch, deleted the lockfile and regenerated it with poetry install (on version 1.4.1). Hope this fixes the issue.

Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will fix our test workflow after merge this PR.

@taobun taobun merged commit 616906e into bandprotocol:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install fails on ledgerblue 0.1.42
3 participants