Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): character page #72

Closed
wants to merge 23 commits into from

Conversation

Ayase-252
Copy link
Contributor

人物页

URL: /character/:id

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #72 (77b092e) into master (6a9a497) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   98.52%   98.60%   +0.07%     
==========================================
  Files          26       27       +1     
  Lines        1018     1076      +58     
  Branches      119      127       +8     
==========================================
+ Hits         1003     1061      +58     
  Misses         15       15              
Impacted Files Coverage Δ
packages/website/src/components/InfoBox/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9a497...77b092e. Read the comment docs.

@github-actions
Copy link
Contributor

storybook preview url: https://pr-72-storybook--bangumi-next.netlify.app

@cokemine
Copy link
Contributor

要不要用 https://swr.vercel.app/zh-CN 数据请求。
感觉写起来会更方便一点

@trim21
Copy link
Contributor

trim21 commented Apr 30, 2022

感觉先不急?登录做完了之后用私有api做?

@Ayase-252
Copy link
Contributor Author

嗯,先画个样子

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

preview url: https://pr-72--bangumi-next.netlify.app

@Ayase-252 Ayase-252 mentioned this pull request Jan 2, 2023
11 tasks
@mergify
Copy link

mergify bot commented Mar 22, 2023

@Ayase-252 this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 22, 2023
@trim21
Copy link
Contributor

trim21 commented Mar 22, 2023

一时半会没影的PR先关了(

@trim21 trim21 closed this Mar 22, 2023
@mergify mergify bot removed the conflict label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants