Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the JRuby 9.2.0.0 source_location hack once the newest version is out #52

Closed
kyrylo opened this issue Nov 2, 2018 · 1 comment
Closed

Revert the JRuby 9.2.0.0 source_location hack once the newest version is out #52

kyrylo opened this issue Nov 2, 2018 · 1 comment

Comments

@kyrylo
Copy link
Collaborator

kyrylo commented Nov 2, 2018

We should revert #51 once JRuby releases the fix for
jruby/jruby#5262 that is currently unreleased by on their master.

The code there is temporary, to let users enjoy JRuby 9.2.0.0 with Pry. Once JRuby 9.2.0.1 or whatnot is released, the patch won't be needed anymore, so it's safe to delete it.
@kyrylo
Copy link
Collaborator Author

kyrylo commented Nov 11, 2018

https://github.com/postmodern/chruby/wiki/JRuby gave me a false impression that 9.2.0.0 was the latest JRuby. It turns out the latest one is 9.2.3.0 🤦‍♂️

kyrylo added a commit that referenced this issue Nov 11, 2018
@kyrylo
Revert "method_source: fix broken Procs on JRuby 9.2.0.0"
48405c4 
Fixes #52 (Revert the JRuby 9.2.0.0 source_location hack once the newest version
is out)

This reverts commit 20fb1ef.
@kyrylo kyrylo mentioned this issue Nov 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyrylo