method_source: fix broken Procs on JRuby 9.2.0.0 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works but not with Pry because it calls different methods. I'll investigate. |
kyrylo
force-pushed
the
jruby-9200-fix
branch
2 times, most recently
from
53a4442
to
3463d44
Compare
|
Okay, I fixed it both here and for Pry. PTAL |
Fixes pry/pry#1804 (JRuby 9.2.0.0 breaks `source_location` and therefore our test suite) JRuby 9.2.0.0 fails to fetch source code for procs because of the bug: jruby/jruby#5262 The problem is that source_location is reported at the end of the proc, instead of the beginning. The way I fix it is rather dumb (rewinding back and checking if it's complete expression) but it's isolated only to 9.2.0.0 and likely won't be needed when another JRuby is released. However, so far it's the latest release.
kyrylo
force-pushed
the
jruby-9200-fix
branch
from
3463d44
to
20fb1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pry/pry#1804
(JRuby 9.2.0.0 breaks
source_locationand therefore our test suite)JRuby 9.2.0.0 fails to fetch source code for procs because of the bug:
jruby/jruby#5262
The problem is that source_location is reported at the end of the proc, instead
of the beginning.
The way I fix it is rather dumb (rewinding back and checking if it's complete
expression) but it's isolated only to 9.2.0.0 and likely won't be needed when
another JRuby is released. However, so far it's the latest release.