Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image annotations #44

Merged
merged 1 commit into from
Oct 30, 2020
Merged

feat: add image annotations #44

merged 1 commit into from
Oct 30, 2020

Conversation

michael-todorovic
Copy link
Contributor

@michael-todorovic michael-todorovic commented Oct 28, 2020 •
edited

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

This PR updates the doc about new annotations to control deployed container images, related to https://github.com/banzaicloud/bank-vaults/pull/1162

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

This was referenced Oct 28, 2020
Closed
Merged
@bonifaido bonifaido self-assigned this Oct 29, 2020
bonifaido
bonifaido approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Waiting for feature PR to be merged.

@bonifaido bonifaido merged commit 8250b2e into bank-vaults:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

Assignees

@bonifaido bonifaido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-todorovic @bonifaido