webhook: annotations to control agent and env images #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-todorovic
requested review from
bonifaido and
pbalogh-sa
as code owners
bonifaido
reviewed
Oct 29, 2020
bonifaido
reviewed
Oct 29, 2020
bonifaido
reviewed
Oct 29, 2020
bonifaido
requested changes
Oct 29, 2020
bonifaido
approved these changes
Oct 29, 2020
bonifaido
changed the title
rrondeau
pushed a commit
to rrondeau/bank-vaults
that referenced
this pull request
Nov 3, 2020
* feat: annotations to control agent and env images * fix: get back default values with viper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds 4 new annotations so we can alter the images for vault agent and vault-env at pod level.
Why?
This is useful when you need to test new images without breaking everything or deploy a whole new environment. This can be useful when you have multiple vaults with different versions, depending on the team. It can be useful if team A has vault v2 with a breaking change from v1 but team B has still vault v1.
Checklist
To Do