Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

休薬終了時に最後に飲んだピル番号が無い場合はピル番号調整のモーダルを出さない #580

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Apr 24, 2022

Abstract

  • 休薬終了時に最後に飲んだピル番号が無い場合はピル番号調整のモーダルを出さない
  • 服用日数表示以外にもモーダルが出ていたのでないようにした
  • analyticsの境界値条件が間違えていたので修正

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review April 24, 2022 23:00
@bannzai bannzai merged commit 05dd17b into main Apr 24, 2022
@bannzai bannzai deleted the bugfix/function/display_end_setting branch April 24, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant