Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database #585

Merged
merged 29 commits into from
May 1, 2022
Merged

Refactor database #585

merged 29 commits into from
May 1, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Apr 27, 2022

Abstract

  • withConvertの使用
    • ただ途中で面倒くさくなってきたので、気づいた部分を置き換える
  • streamを統一する
    • StreamProviderも検討したが、大きく書き換えるのも微妙だったのでやめる。あとはdatastoreの役割を用意してそれを崩すことはないので、今まで通りdatastoreに持たせれば良いだろう。と思った

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit 2d15d19 into main May 1, 2022
@bannzai bannzai deleted the refactor/function/database branch May 1, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant