Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivias fixes #618

Merged
merged 7 commits into from
Jun 9, 2022
Merged

Trivias fixes #618

merged 7 commits into from
Jun 9, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jun 9, 2022

Abstract

  • カウントダウンのUIの改行が一つ多かったので修正
  • AndroidのInAppReviewがメッセージ必須でうざかったので7回に1度のタイミングで出るのは少しユーザーにとってネガティブに思えた。28回に1回に変更する

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review June 9, 2022 23:03
@bannzai bannzai merged commit 9e6222e into main Jun 9, 2022
@bannzai bannzai deleted the enhancement/trivias branch June 9, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant