Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading until button process is end #630

Merged
merged 15 commits into from
Jul 11, 2022
Merged

Show loading until button process is end #630

merged 15 commits into from
Jul 11, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jun 26, 2022

Abstract

ローカルのデータが更新されたタイミングで処理を進めて良い場所についてはawaitを消す

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai
Copy link
Owner Author

bannzai commented Jun 26, 2022

Primary,Undo,Redまでは動作確認済み

@bannzai bannzai changed the title Remove await Show loading until button process is end Jul 11, 2022
@bannzai bannzai merged commit be2ec57 into main Jul 11, 2022
@bannzai bannzai deleted the remove/logic/await branch July 11, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant