Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runZonedGuardedで初期化処理を実行する #632

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jun 30, 2022

Abstract

runZonedGuardedで初期化処理を実行する。主にFirebaseCrashlyticsを利用するために変更

Why

https://firebase.google.com/docs/crashlytics/get-started?platform=flutter#add-sdk
よく見たら宣言位置が違った。全部runZonedGuardedに入れても問題なさそうだったのでそうする

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai
Copy link
Owner Author

bannzai commented Jun 30, 2022

動作確認するまでDraft

@bannzai bannzai marked this pull request as draft June 30, 2022 22:17
@bannzai bannzai marked this pull request as ready for review July 4, 2022 23:20
@bannzai bannzai merged commit 1f986f3 into main Jul 4, 2022
@bannzai bannzai deleted the fix/function/entrypoint branch July 4, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant