Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeline #682

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Fix timeline #682

merged 3 commits into from
Sep 17, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Sep 16, 2022

Abstract

WidgetKitのtimeline providerの修正。.after(interval)をしておけばintervalごとにtimelineの更新が走りそうなのでそれだけにした

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit 3ff3f5c into main Sep 17, 2022
@bannzai bannzai deleted the fix/widget/timeline branch September 17, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant