Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove generic admission server #40

Closed
wants to merge 67 commits into from

Conversation

pbalogh-sa
Copy link
Member

Q A
Bug fix? no
New feature? yes
Deprecations? yes
Related tickets fixes #38
License Apache 2.0

What's in this PR?

This PR removes genereic-admission-server and implements pure webhook functionality.
Theanchore-policy-validator chart is updated and moved to this repo.

Why?

Without generic-admission-server debugging the validator is more simple.

To Do

  • The chart was moved to this repo, some discussion is needed due to the security scan feature of the Pipeline.
  • After the discussion, the original chart should be removed from banzai-charts repo.

pbalogh-sa and others added 30 commits September 17, 2018 19:36
* create policy bundles and activate AllowAll by default
* add pre and post delete helm hook

* add release namespace in delet hooks

* in case of clusterroles remove unnecessary namespace in delete hook
* add maintainers to all charts

* Update Chart.yaml
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
…emove-generic-admission-server' of github.com/banzaicloud/anchore-image-validator
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lgtm"

@pbalogh-sa pbalogh-sa changed the title Remove generic admission server [WIP] Remove generic admission server Dec 18, 2019
@pbalogh-sa
Copy link
Member Author

pbalogh-sa commented Dec 18, 2019

It is separated into two pieces. #41 #42

@pbalogh-sa pbalogh-sa closed this Dec 18, 2019
@pbalogh-sa pbalogh-sa deleted the remove-generic-admission-server branch December 19, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move anchore-policy-validator chart into this repo
4 participants