Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop generic admission server #42

Merged
merged 19 commits into from
Dec 18, 2019
Merged

Drop generic admission server #42

merged 19 commits into from
Dec 18, 2019

Conversation

pbalogh-sa
Copy link
Member

@pbalogh-sa pbalogh-sa commented Dec 18, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? yes
License Apache 2.0

What's in this PR?

This PR removes genereic-admission-server and implements pure webhook functionality.

Why?

Without generic-admission-server debugging the validator is more simple, and less privilege is needed for serviceaccount used by validator

To Do

  • The chart was moved to this repo, some discussion is needed due to the security scan feature of the Pipeline.
  • After the discussion, the original chart should be removed from banzai-charts repo.

@pbalogh-sa
update remove generic-admission-server
c9463bf 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
udate dockerfiles
52ba64e 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
drop generic-admission-server and move out validation
65af91d 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
use controller-runtime
6789cc3 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update license header
ef7180f 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
add config
e1e900e 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
add log
301cbc0 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
move validation to internal
841787a 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
use controller-runtime in handler
6df860d 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update charts
ac2b3be 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
minor fixes for health check
22d966a 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
cleanup self
9dcd867 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
fix lint
e63783e 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
implement original logic
cb67add 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
minor fixes
366a985 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update go version in circleci config
3b47380 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
fix licensei and check-header
536f865 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa pbalogh-sa mentioned this pull request Dec 18, 2019
Closed
@pbalogh-sa
update license header
fb7303f 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
permission cleanup
4c43b76 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa pbalogh-sa merged commit 467f11b into master Dec 18, 2019
@pbalogh-sa pbalogh-sa deleted the drop-generic-admission-server branch December 19, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

@pepov pepov pepov approved these changes

@tarokkk tarokkk Awaiting requested review from tarokkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbalogh-sa @bonifaido @pepov