Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Kafka broker image version (3.1.0->)3.1.2 #1005

Merged
merged 2 commits into from Jul 12, 2023
Merged

Updated Kafka broker image version (3.1.0->)3.1.2 #1005

merged 2 commits into from Jul 12, 2023

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Jul 6, 2023 •
edited

Description

To fix vulnerabilities and incorporate patches.
Based on #774

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pregnor pregnor added the enhancement New feature or request label Jul 6, 2023
@pregnor pregnor requested a review from a team July 6, 2023 11:24
@pregnor pregnor self-assigned this Jul 6, 2023
bartam1
bartam1 previously approved these changes Jul 6, 2023
View reviewed changes
panyuenlau
panyuenlau previously approved these changes Jul 6, 2023
View reviewed changes
@panyuenlau
Copy link
Member

Question: is this PR still needed given we have #1007 and #1006 ready to be merged?

@pregnor
Copy link
Member Author

pregnor commented Jul 12, 2023 •
edited

Question: is this PR still needed given we have #1007 and #1006 ready to be merged?

I would say not required with those.
But if we need to wait for long before merging those PRs this could go in fast and have a fresher version by default in Koperator.

Edit: If we want a consistent state between the components support 3.1.2 which is required for a user then this should be merged before 3.4 stuff IMO.
What do you think?

@pregnor pregnor merged commit 714d07b into master Jul 12, 2023
3 checks passed
@pregnor pregnor deleted the fix/kafka-3-1-2 branch July 12, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyuenlau panyuenlau panyuenlau approved these changes

@bartam1 bartam1 bartam1 approved these changes

@mihaialexandrescu mihaialexandrescu Awaiting requested review from mihaialexandrescu

Assignees

@pregnor pregnor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pregnor @panyuenlau @mihaialexandrescu @bartam1