Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kafka up to 3.4.1 #1006

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Support Kafka up to 3.4.1 #1006

merged 2 commits into from
Jul 13, 2023

Conversation

panyuenlau
Copy link
Member

@panyuenlau panyuenlau commented Jul 10, 2023 •
edited
Loading

Description

Add support for Kafka up to v3.4.1

Smoke test

  • Kafka cluster with PLAINTEXT listeners
  • Kafka cluster with SSL internal and external listeners
  • Kafka cluster with ACL enabled while using SSL for both internal and external listeners
  • Brokers scaling

Note: the image built with the change in this PR banzaicloud/docker-kafka#32 was used for the above smoke tests

Type of Change

  • New Feature

Checklist

  • I have read the contributing guidelines
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@panyuenlau panyuenlau requested a review from a team as a code owner July 10, 2023 18:20
@panyuenlau panyuenlau mentioned this pull request Jul 10, 2023
Merged
8 tasks
Kuvesz
Kuvesz previously approved these changes Jul 11, 2023
View reviewed changes
@panyuenlau panyuenlau mentioned this pull request Jul 11, 2023
Merged
8 tasks
@panyuenlau panyuenlau requested review from a team and Kuvesz July 12, 2023 18:35
pregnor
pregnor approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyuenlau panyuenlau merged commit 3f2d95a into master Jul 13, 2023
@panyuenlau panyuenlau deleted the kafka-3.4 branch July 13, 2023 12:47
@panyuenlau panyuenlau mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuvesz Kuvesz Kuvesz approved these changes

@pregnor pregnor pregnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panyuenlau @pregnor @Kuvesz