Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth and access tokens - [PIP-25] #135

Closed
wants to merge 7 commits into from
Closed

Conversation

matyix
Copy link
Member

@matyix matyix commented Jan 13, 2018

This work is intended to introduce GitHub OAuth authentication and JWT based authentication to the project. Authentication is done at http://127.0.0.1:9090/auth/login address. Token generation is possible after this at http://127.0.0.1:9090/api/v1/token right now in the browser only.

Requirements:

  • Registering a GitHub OAuth application and provide the ClientID and ClientSecret in the config.toml file (callback is http://127.0.0.1:9090/auth/github/callback)

Some leftovers:

  • JWT Token signing is symmetric (HS256) right now, it should be asymmetric (RS256) for increased security
  • Valid tokens are stored in-memory right now, but these tokens should be stored in some kind of fast persistent storage, behind the TokenStore interface.

@matyix matyix closed this Jan 18, 2018
@matyix matyix deleted the oauth-and-access-tokens branch January 18, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant