eks: fix resource id path handling in IAM #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
changed the title
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
pepov
approved these changes
Feb 5, 2020
bonifaido
changed the title
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
changed the title
tarokkk
approved these changes
Feb 5, 2020
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
tarokkk
approved these changes
Feb 5, 2020
kozmagabor
approved these changes
Feb 5, 2020
This was referenced Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandor Kracser bonifaido@gmail.com
What's in this PR?
The EKS code couldn't handle IAM resources defined by full path, this PR fixes that.
Why?
To handle resources under paths (other than "/").
Additional context
Also this fixes
packageCFErrorformatting.Splitting is possible in CF as well and also selection from an array, but selecting the last element from and array/list is not possible easily, so the extraction is done in the surrounding Go code.
Checklist