Fix forced integer to bitmap casts #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Martins <josemartins90@gmail.com>
Signed-off-by: Jose Martins <josemartins90@gmail.com>
ninolomata
approved these changes
Jul 28, 2023
|
Just tested on RISC-V in QEMU and issue #78 is fixed. |
DavidMCerdeira
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use some of the operations defined for the
bitmap_t*type, some functions were casting integer types pointers tobitmap_t*. This is not the best practice and was causing some issues with the latest GCC versions, as pointed out in #78.This PR fixes this issue by refactoring these operations using simple bit manipulation functions available in bit/util/bit.h. However, it was still needed to add the
bit_ffsandbit_countfunctions so that all functionality needed was available.