Colab end-to-end runnable version #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Showing time left - Showing image progression - Simplified and remove unused variables
- Simplified cell usage - Added configuration section at top
Improvements to Colab notebook (Better code, but broken interpolation because of the python file.)
- Improved Collab notebook readme cell - Added configuration for `FRAME_INPUT_DIR` - Added configuration for `FRAME_OUTPUT_DIR` - Showing a bit more info about the GPU Card (some drivers might actually not run) - Fixed git clone directory path - Passing `start_frame` and `end_frame` as parameters to the python script (to allow for resuming runs) - Avoid outputs middle-steps
Added parameters, fixed interpolation estimation, cleaner code, updated readme
|
I downloaded I imagine that once merged, the repository URL inside the notebook should be updated to point to this repository again. The only issue I had was mere oversight on my part: not paying attention to partial frames, e.g. a 12.5 FPS video does not upconvert in an integer fashion to 60 FPS. 63 FPS is closer to ideal. |
vlee-harmonicinc
pushed a commit
to vlee-harmonicinc/DAIN
that referenced
this pull request
May 14, 2020
Colab end-to-end runnable version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Along with the help of @styler00dollar, we've created a Python Notebook that can be run in Google Colaboratory for free. We also integrated it with Google Drive and ffmpeg, which means that we can do quick end-to-end tests with input and output files that we carry on.
We're basing our tests from the
bestmodel and the DAIN_slowmotion network, but with this, making modifications it's very easy.We believe that this is a good addition to the original repository, both as a demonstration of how to use the existing code (in real world scenarios) and also as a way for experimenters to run it without the need of a local setup.
We welcome any feedback!