🐛 (setVariable) Avoid octal number evalution

baptisteArno · Jan 29, 2024 · ef05b71 · ef05b71
1 parent 5f0b369
commit ef05b71
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/bot-engine/blocks/logic/setVariable/executeSetVariable.ts b/packages/bot-engine/blocks/logic/setVariable/executeSetVariable.ts
@@ -63,6 +63,8 @@ const evaluateSetVariableExpression =
     const isSingleVariable =
       str.startsWith('{{') && str.endsWith('}}') && str.split('{{').length === 2
     if (isSingleVariable) return parseVariables(variables)(str)
+    // To avoid octal number evaluation
+    if (!isNaN(str as unknown as number) && /0[^.].+/.test(str)) return str
     const evaluating = parseVariables(variables, { fieldToParse: 'id' })(
       str.includes('return ') ? str : `return ${str}`
     )

diff --git a/packages/embeds/js/src/features/blocks/logic/setVariable/executeSetVariable.ts b/packages/embeds/js/src/features/blocks/logic/setVariable/executeSetVariable.ts
@@ -9,6 +9,11 @@ export const executeSetVariable = async ({
   args,
 }: ScriptToExecute): Promise<{ replyToSend: string | undefined }> => {
   try {
+    // To avoid octal number evaluation
+    if (!isNaN(content as unknown as number) && /0[^.].+/.test(content))
+      return {
+        replyToSend: content,
+      }
     const func = AsyncFunction(
       ...args.map((arg) => arg.id),
       content.includes('return ') ? content : `return ${content}`