Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloop for constructors #51

Merged
merged 8 commits into from
Sep 9, 2022
Merged

Preloop for constructors #51

merged 8 commits into from
Sep 9, 2022

Conversation

d-schindler
Copy link
Collaborator

I've implemented a preloop that computes constructors for all Markov scales in a parallelised way and stores them for later use. I hope this speeds up the process because computing the constructors is the bottleneck of MS analysis, which was previously not parallelised. The implementation seems to work but speed increase needs to be checked.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #51 (845148d) into master (f00fd8e) will decrease coverage by 2.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   41.85%   39.40%   -2.46%     
==========================================
  Files           8        8              
  Lines         571      571              
==========================================
- Hits          239      225      -14     
- Misses        332      346      +14     
Flag Coverage Δ
pytest 39.40% <100.00%> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pygenstability/constructors.py 89.74% <100.00%> (-0.86%) ⬇️
src/pygenstability/pygenstability.py 80.62% <100.00%> (-10.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-schindler
Copy link
Collaborator Author

The implementation of the pre-loop is completed, should we merge into master? I guess some of the checks fail because of code syntax..

@arnaudon
Copy link
Collaborator

thank a lot, I'll take a look and merge it asap!

@arnaudon arnaudon self-assigned this Jun 21, 2022
@arnaudon arnaudon enabled auto-merge (squash) September 9, 2022 12:32
@arnaudon arnaudon merged commit a0e7369 into master Sep 9, 2022
@arnaudon arnaudon deleted the preloop branch September 9, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants