Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error ErrNotFile returned when extracting metadata from folder #55

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Error ErrNotFile returned when extracting metadata from folder #55

merged 2 commits into from
Apr 10, 2022

Conversation

barasher
Copy link
Owner

Fix for issue #52
@jnathanh

@barasher barasher added this to the v1.7.1 milestone Mar 29, 2022
@barasher barasher self-assigned this Mar 29, 2022
@barasher barasher mentioned this pull request Mar 29, 2022
Closed
@barasher
Copy link
Owner Author

@jnathanh

jnathanh
jnathanh approved these changes Mar 30, 2022
View reviewed changes
Copy link

@jnathanh jnathanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest focusing the test specifically on the directory behavior (not on the full buffer issue that originally prompted this pr). Otherwise looks good!

exiftool.go Show resolved Hide resolved
exiftool_test.go Outdated Show resolved Hide resolved
exiftool_test.go Outdated Show resolved Hide resolved
@barasher barasher merged commit c725199 into master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnathanh jnathanh jnathanh approved these changes

Assignees

@barasher barasher

Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barasher @jnathanh