Chore/update php cs fixer #600
Conversation
|
Both referenced pull requests have been merged. This requires a rebase now. |
aragon999
force-pushed
the
chore/update-php-cs-fixer
branch
3 times, most recently
from
00c1aef
to
cecd897
Compare
|
I rebased, but I am quite confused why the merge commit is still shown in this PR. Locally everything seems fine, as far as I can tell: Edit: I just noticed, that the merge is missing for the |
|
The The mentioned commits / pull requests were only merged to develop. I'm already thinking about removing this develop branch as it doesn't really make sense in this project. We could also simply branch from the default branch. But for now: Develop. :) |
aragon999
force-pushed
the
chore/update-php-cs-fixer
branch
from
cecd897
to
4f96210
Compare
|
Thanks for the feedback. Yeah I mean the branches really depend on the desired workflow. Personally I actually like to work with a |
|
Approved - checks are running. One already failed. 🙈 Yeah, there are a lot of different approaches to how to work with branches and every company or whatever is handling it more or less different. :D |
aragon999
force-pushed
the
chore/update-php-cs-fixer
branch
from
4f96210
to
408c927
Compare
aragon999
force-pushed
the
chore/update-php-cs-fixer
branch
from
408c927
to
0257663
Compare
|
Yes, sorry I forgot some changes, and did not check properly what has changed in the I added some changes, but unfortunately locally the psalm command still fails: Although I updated psalm to the version which should include this option. Not sure, hope the pipelines do not fail anymore. |
|
I just checked, for me psalm also fails locally without my changes. I can also not find the attribute in the XML schema: https://psalm.dev/schema/config |
|
Let's fix these issues in a different merge request. |
This pull request currently includes #595 (since this does some prior work) and #598 (which I needed since I am running php8) if these two pull requests are merged I am happy to rebase this PR.