Issue/592

[bapcltd-marv]

re: #592

generating code coverage should be possible, although personally I switched our fork to codecov a while ago.

[Sebbo94BY]

Would be also cool to integrate the respective badge in the README. :)

[![CI](https://github.com/barbushin/php-imap/actions/workflows/php.yml/badge.svg)](https://github.com/barbushin/php-imap/actions/workflows/php.yml)

[bapcltd-marv]

This PR now integrates changes that would close #593 and #599

[bapcltd-marv]

@Sebi94nbg should travis be dropped as part of this PR?

[Sebbo94BY]

@Sebi94nbg should travis be dropped as part of this PR?

If both are doing the same, I would say yes as we otherwise would only need to manage the same thing twice.

[bapcltd-marv]

@Sebi94nbg should travis be dropped as part of this PR?

If both are doing the same, I would say yes as we otherwise would only need to manage the same thing twice.

The only issue at present is this PR isn't set up to generate coverage reports, I'll give the codeclimate action a go without using a hardcoded reporter ID.

[bapcltd-marv]

@Sebi94nbg should travis be dropped as part of this PR?

If both are doing the same, I would say yes as we otherwise would only need to manage the same thing twice.

The only issue at present is this PR isn't set up to generate coverage reports, I'll give the codeclimate action a go without using a hardcoded reporter ID.

per 993b51b, travis has been dropped.
per 0746e30, the reporter ID should be added as a repo secret, to make it easier to manage forks.

[Sebbo94BY]

Alright. Can I merge it now? Or are you still changing something on it? :D

[bapcltd-marv]

Alright. Can I merge it now? Or are you still changing something on it? :D

• the code climate reporter ID needs to be added to the repo secrets via CC_TEST_REPORTER_ID
• OR the commit that removed the hardcoded value needs to be reverted
• the branch configs need to be cleaned up after merging so they no longer trigger mostly just for this branch
• the "drop php 7.2" issues need to be closed
• the code style issues referenced in Using deprecated php-cs-fixer methods #594 need to be resolved so the CI action passes (outside the scope of my current dayjob responsibilities)

[Sebbo94BY]

• the code climate reporter ID needs to be added to the repo secrets via CC_TEST_REPORTER_ID

@barbushin can you please set the secret / environment variable in the repository settings? You're the only one, who has the permissions to do this. :)

Otherwise we need to keep the secret in Git, what is not that beautiful.

[bapcltd-marv]

Otherwise we need to keep the secret in Git, what is not that beautiful.

it's more a matter of making it easier to manage coverage in forks.

Should I keep my Test Reporter ID secret?
Your repo's test coverage ID is only used to identify your repo when submitting test coverage payloads. It can't be used to access any of your data.

https://docs.codeclimate.com/docs/finding-your-test-coverage-token

[Sebbo94BY]

I'll merge this now in order to fix the cs-fixer issues in the pipeline.