unittest: setting up test

Test crashes in case the checks do not work properly

core/src/tests/CMakeLists.txt

@@ -468,3 +468,11 @@ endif() # NOT client-only
 if(NOT client-only)
   bareos_add_test(select_functions LINK_LIBRARIES dird_objects bareosfind bareossql GTest::gtest_main)
 endif() # NOT client-only
+
+if(NOT client-only)
+  bareos_add_test(
+    dir_fd_connection
+    LINK_LIBRARIES testing_common dird_objects bareos bareossql bareosfind
+                   GTest::gtest_main
+  )
+endif() # NOT client-only

core/src/tests/configs/dir_fd_connection/dir_to_fd_connection_no/bareos-dir.d/client/fd-no-connection.conf

@@ -0,0 +1,6 @@
+Client {
+  Name = fd-no-connection
+  Address = localhost
+  Password = ""
+  Connection From Director To Client = no
+}

core/src/tests/dir_fd_connection.cc

@@ -0,0 +1,46 @@
+/*
+   BAREOS® - Backup Archiving REcovery Open Sourced
+
+   Copyright (C) 2022-2022 Bareos GmbH & Co. KG
+
+   This program is Free Software; you can redistribute it and/or
+   modify it under the terms of version three of the GNU Affero General Public
+   License as published by the Free Software Foundation and included
+   in the file LICENSE.
+
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+   Affero General Public License for more details.
+
+   You should have received a copy of the GNU Affero General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301, USA.
+*/
+
+#include "testing_dir_common.h"
+
+#include "dird/ua.h"
+#include "dird/fd_cmds.cc"
+#include "dird/job.cc"
+
+TEST(DirectorToClientConnection, DoesNotConnectWhenDisabled)
+{
+  InitDirGlobals();
+  std::string path_to_config
+      = std::string(RELATIVE_PROJECT_SOURCE_DIR
+                    "/configs/dir_fd_connection/dir_to_fd_connection_no/");
+
+  PConfigParser director_config(DirectorPrepareResources(path_to_config));
+
+
+  JobControlRecord* jcr = directordaemon::NewDirectorJcr();
+
+  jcr->impl->res.client = static_cast<directordaemon::ClientResource*>(
+      directordaemon::my_config->GetResWithName(directordaemon::R_CLIENT,
+                                                "fd-no-connection"));
+  directordaemon::UaContext* ua = nullptr;
+
+  EXPECT_FALSE(ConnectToFileDaemon(jcr, 0, 0, false, ua));
+}

core/src/tests/testing_common.h

@@ -24,11 +24,11 @@
 
 #if defined(HAVE_MINGW)
 #  include "include/bareos.h"
-#  include "gtest/gtest.h"
-#else
-#  include "gtest/gtest.h"
 #endif
 
+#include "gtest/gtest.h"
+#include "gmock/gmock.h"
+
 #include "lib/parse_conf.h"
 
 typedef std::unique_ptr<ConfigurationParser> PConfigParser;

core/src/tests/testing_dir_common.cc

@@ -49,7 +49,6 @@ PConfigParser DirectorPrepareResources(const std::string& path_to_config)
   EXPECT_TRUE(parse_director_config_ok) << "Could not parse director config";
   if (!parse_director_config_ok) { return nullptr; }
 
-  Dmsg0(200, "Start UA server\n");
   directordaemon::me
       = (directordaemon::DirectorResource*)director_config->GetNextRes(
           directordaemon::R_DIRECTOR, nullptr);