Do not call fdatasync() and fix m_flags->flags_

Fixes #1227: Fix fadvise bug Suggested changes implemented: - #496 (comment) - #496 (comment)
bareos · Apr 30, 2020 · ea66639 · ea66639
1 parent f3bd208
commit ea66639
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/core/src/findlib/bfile.cc b/core/src/findlib/bfile.cc
@@ -1187,8 +1187,7 @@ int bclose(BareosWinFilePacket* bfd)
   } else {
 #if defined(HAVE_POSIX_FADVISE) && defined(POSIX_FADV_DONTNEED)
     /* If not RDWR or WRONLY must be Read Only */
-    if (!(bfd->m_flags & (O_RDWR|O_WRONLY))) {
-      fdatasync(bfd->fid); /* sync the file */
+    if (!(bfd->flags_ & (O_RDWR|O_WRONLY))) {
       /* Tell OS we don't need it any more */
       posix_fadvise(bfd->fid, 0, 0, POSIX_FADV_DONTNEED);
       Dmsg1(400, "Did posix_fadvise DONTNEED on fid=%d\n", bfd->fid);