Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compiler flags to correct spelling #101

Merged
merged 1 commit into from Aug 23, 2018

Conversation

simonkrahe
Copy link
Contributor

Compiler flags were labelled incorrectly and thus not recognized by the compiler. This didn't show up as an error, as the installation was able to correctly finish anyway. However, specifying the directories was not possible in usecases where it was required.

Additional flags are not being used, although they might have to be:

[  192s] CMake Warning:
[  192s]   Manually-specified variables were not used by the project:
[  192s] 
[  192s]     CMAKE_EXPORT_NO_PACKAGE_REGISTRY
[  192s]     bat
[  192s]     disable-conio
[  192s]     includes
[  192s]     pid-dir
[  192s]     python
[  192s]     readline
[  192s]     rpath
[  192s]     sbin-perm
[  192s]     subsys-dir
[  192s]     tcp-wrappers
[  192s]     working-dir
[  192s]     xattr

(seen in our internal build log)

Further inspection of

core/platforms/packaging/bareos.spec
core/debian/rules
core/cmake/BareosSetVariableDefaults.cmake

yielded:
rpath is not mentioned in neither core/cmake/BareosSetVariableDefaults.cmake or core/platforms/packaging/bareos.spec

@joergsteffens joergsteffens merged commit f62879d into bareos:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants