tests: simplify test coverage analysis #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
changed the title
pstorz
force-pushed
the
dev/arogge/master/improve-bsnprintf
branch
from
beb53ab
to
7cd8330
Compare
pstorz
force-pushed
the
dev/arogge/master/improve-bsnprintf
branch
2 times, most recently
from
1494e07
to
8427211
Compare
This patch adds two new custom targets to CMake if building with coverage enabled. cov-report: will generate a coverage report in CMAKE_BINARY_DIR/coverage cov-clean: will wipe out the coverage report cov-report generates and will also remove the gcda files in the build tree resetting the collected coverage information. Previously the ctest pretest executed the director binary which would add misleading information to the coverage report (i.e. director code was run wheter or not you were running a director test). This patch also changes the pretest to just check for the executable instead of calling it.
pstorz
force-pushed
the
dev/arogge/master/improve-bsnprintf
branch
from
4a2d35a
to
0a2683f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to simplify analysis of test coverage in Bareos.
A new chapter is added to the documentation, describing how to analyse coverage. To simplify the whole process custom targets have been added to CMake and some minor issues have been fixed.
In the process of doing this, a test-suite for Bsnprintf() was also created.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests