-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create MariaDB mariabackup plugin chapter #1016
docs: create MariaDB mariabackup plugin chapter #1016
Conversation
Actually a blind manual test following the documentation is needed to validate the order of operation. |
98912ba
to
5b6accf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, please check my suggestions if they make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good for me
889d2a6
to
824b7dd
Compare
- Add a mariadb replacement shortcut in conf.py - Remove MariaDB from mysql shortcut in conf.py Used mysql shortcuts are about catalog (deleted in next Bareos 21 version) - Rework and adjust Perconna XtraBackup chapter with actual information (version supported, examples, documentation link) - Add mariabackup plugin chapter Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
As Bareos 21 was released, 18.2 is EOL and not supported anymore.
824b7dd
to
d6475af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, however
- CHANGELOG.md entry is missing.
- One small change of the text.
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Used mysql shortcuts are about catalog (deleted in next Bareos 21 version)
(version supported, examples, documentation link)
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testing