Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create MariaDB mariabackup plugin chapter #1016

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Dec 8, 2021

  • Add a mariadb replacement shortcut in conf.py
  • Remove MariaDB from mysql shortcut in conf.py
    Used mysql shortcuts are about catalog (deleted in next Bareos 21 version)
  • Rework and adjust Perconna XtraBackup chapter with actual information
    (version supported, examples, documentation link)
  • Add mariabackup plugin chapter

Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos
Copy link
Contributor Author

Actually a blind manual test following the documentation is needed to validate the order of operation.

@arogge arogge marked this pull request as draft December 9, 2021 10:29
@arogge arogge removed the draft label Dec 9, 2021
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/docs-plugins-xtrabackup-mariadbackup branch from 98912ba to 5b6accf Compare December 21, 2021 14:14
@bruno-at-bareos bruno-at-bareos changed the title [WIP] docs: create MariaDB mariabackup plugin chapter docs: create MariaDB mariabackup plugin chapter Dec 21, 2021
@bruno-at-bareos bruno-at-bareos marked this pull request as ready for review December 21, 2021 14:17
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, please check my suggestions if they make sense.

docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/docs-plugins-xtrabackup-mariadbackup branch from 889d2a6 to 824b7dd Compare December 23, 2021 13:53
bruno-at-bareos and others added 2 commits January 10, 2022 14:45
- Add a mariadb replacement shortcut in conf.py
- Remove MariaDB from mysql shortcut in conf.py
  Used mysql shortcuts are about catalog (deleted in next Bareos 21 version)
- Rework and adjust Perconna XtraBackup chapter with actual information
  (version supported, examples, documentation link)
- Add mariabackup plugin chapter

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
As Bareos 21 was released, 18.2 is EOL and not supported anymore.
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/docs-plugins-xtrabackup-mariadbackup branch from 824b7dd to d6475af Compare January 10, 2022 13:50
@pstorz pstorz self-assigned this Jan 10, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, however

  • CHANGELOG.md entry is missing.
  • One small change of the text.

docs/manuals/source/TasksAndConcepts/Plugins.rst Outdated Show resolved Hide resolved
bruno-at-bareos and others added 2 commits January 13, 2022 13:23
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 37d2fca into bareos:master Jan 13, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/docs-plugins-xtrabackup-mariadbackup branch January 13, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants