Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct packages_dir when releasing restapi to pypi #1033

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Use correct packages_dir when releasing restapi to pypi #1033

merged 2 commits into from
Dec 22, 2021

Conversation

arogge
Copy link
Member

@arogge arogge commented Dec 21, 2021 •
edited by joergsteffens
Loading

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted

@arogge arogge changed the title Use currect packages_dir when releasing restapi to pypi Use correct packages_dir when releasing restapi to pypi Dec 21, 2021
@joergsteffens joergsteffens mentioned this pull request Dec 21, 2021
Closed
16 tasks
joergsteffens
joergsteffens approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the missing CHANGELOG entry, this is good.

@arogge arogge force-pushed the dev/arogge/master/restapi-workflow branch from 0b6f4eb to af51e16 Compare December 21, 2021 14:50
@joergsteffens joergsteffens merged commit 3192b1d into bareos:master Dec 22, 2021
@joergsteffens joergsteffens mentioned this pull request Dec 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joergsteffens joergsteffens joergsteffens approved these changes

Assignees
No one assigned
Labels
requires backport to 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arogge @joergsteffens