-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dir, stored: start statistics threads only if needed #1040
dir, stored: start statistics threads only if needed #1040
Conversation
4cf3c5d
to
8591cd0
Compare
9370a04
to
e73e565
Compare
8c19271
to
ef6947b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that handles the return status of StartStatisticsThread() in both storage and director needs to be added.
Good work!
82df1d7
to
8f34523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, however I would use M_ERROR_TERM instead of M_WARNING if the statistics thread is required but cannot be started. This probably is a serious problem.
Other than that, the last commit message could be reformatted as it has a single "s" in one line that needs to be removed.
Thank you!
21edc97
to
502f282
Compare
34f81ff
to
c1c9bf3
Compare
c1c9bf3
to
ac40b3c
Compare
04d7bc6
to
d347940
Compare
also refactoring addresses and ports test
d347940
to
b84df04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Description:
The director statistics thread starts even when not needed. In order to optimize and have less unnecessary workload, the statistics thread for the director is not started by default, unless
collect statistics
andstatistics collect interval
are both specified.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testing