dird: extend the list command to be able to query volumes and pools by ID

[alaaeddineelamri]

Description:

This PR extends the list command to give the user the ability to list volumes by ID using list volumeid=xx or list mediaid=xx. Also it give the ability to list pools by Id using list poolid=xx

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

• PR name is meaningful
• Purpose of the PR is understood
• Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
• Commit descriptions are understandable and well formatted

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR
• bareos-check-sources --since-merge does not report any problems
• git status should not report modifications in the source tree after building and testing

Tests

• Decision taken that a system- or unittest is required (if not, then remove this paragraph)
• The decision towards a systemtest is reasonable compared to a unittest
• Testname matches exactly what is being tested
• Output of the test leads quickly to the origin of the fault

[franku]

Started a review. Looks good so far, pls read my comments.

[alaaeddineelamri]

Started a review. Looks good so far, pls read my comments.

Thanks for the review @franku ! We assigned you by mistake as a reviewer, but it's the good kind of mistake :D

[fbergkemper]

I'd change the PR subject to something like ...

dird: extend the list command to be able to query volumes and pools by ID

... which I think is more precise.

The PR description should be adjusted in that way and also mention the newly introduced arguments poolid, mediaid/volumeid, I feel.

[fbergkemper]

I'd split commit e71aa10 into two separate ones.

a) docs: update list command documentation
b) dird: add newly introduced list command arguments to the command line help

[fbergkemper]

I'd squash 910394a into bfe6e03 .

[fbergkemper]

I think 8a49a2b should be squashed into 3eb67fc .

[fbergkemper]

I'd also squash 73548f2 into 3eb67fc

[fbergkemper]

Regarding commit 9a9d744 :

To be consistent the commit title/subject should be "Update CHANGELOG.md" as we usually do for these types of commits.

[fbergkemper]

Looks good to me.