Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtests: wait for mariadb shutdown #1048

Merged

Conversation

arogge
Copy link
Member

@arogge arogge commented Jan 17, 2022

The mariabackup plugin test did not wait for mariadb to shutdown after
killing it. This could lead to situations where mariadb was still
running but there was no pid file, eventually failing the test.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@pstorz pstorz self-requested a review January 19, 2022 09:22
@pstorz pstorz self-assigned this Jan 19, 2022
arogge and others added 2 commits January 27, 2022 16:10
The mariabackup plugin test did not wait for mariadb to shutdown after
killing it. This could lead to situations where mariadb was still
running but there was no pid file, eventually failing the test.
@pstorz pstorz force-pushed the dev/arogge/master/fix-mariabackup-shutdown-race branch from 4e18b8f to cc0ffbf Compare January 27, 2022 15:12
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit a098fca into bareos:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants