Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: remove an unnecessary .bvfs_get_jobids and buildSubtree() call #1050

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Jan 18, 2022

The purpose of this PR is to get rid of an unnecessary .bvfs_get_jobids and buildSubtree() call.

This PR also introduces new restore controller functions to eliminate redundant
controller code.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@fbergkemper fbergkemper self-assigned this Jan 18, 2022
@fbergkemper fbergkemper changed the title webui: optimze and refactor restore controller webui: optimize and refactor restore controller Jan 18, 2022
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/s5024 branch 3 times, most recently from dd0b489 to c9db4a5 Compare January 20, 2022 11:41
@fbergkemper fbergkemper changed the title webui: optimize and refactor restore controller webui: remove an unnecessary .bvfs_get_jobids and buildSubtree() call Feb 3, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 746e7a1 into master Feb 4, 2022
@pstorz pstorz deleted the dev/fbergkemper/master/s5024 branch February 4, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants