webui: fix empty job timeline issue if date.timezone is not set in php.ini #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbergkemper
force-pushed
the
dev/fbergkemper/master/s5049
branch
5 times, most recently
from
c605d8f
to
7e6f6d3
Compare
pstorz
changed the title
pstorz
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Good work.
I would suggest to change the commit message as follows:
webui: fix empty job timeline issue if date.timezone is not set in php.ini
This PR fixes an issue where the job timeline stays empty if the timezone
parameter is not set in the php.ini configuration file.
If the timezone is unset it will be set to UTC.
Other than that I have small suggestions for text changes. I hope you agree with my suggestions.
docs/manuals/source/IntroductionAndTutorial/InstallingBareosWebui.rst
Outdated
Show resolved
Hide resolved
fbergkemper
changed the title
…p.ini This PR fixes an issue where the job timeline stays empty if the timezone parameter is not set in the php.ini configuration file. If the timezone is unset it will be set to UTC.
fbergkemper
force-pushed
the
dev/fbergkemper/master/s5049
branch
from
7e6f6d3
to
db60da5
Compare
pstorz
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the job timeline stays empty if the timezone
parameter is not set in the php.ini configuration file.
If the timezone is unset it will be set to UTC.
Also this PR adds a php.ini settings section to the installation chapter of the webui.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing