Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup .gitignore files #1067

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Feb 9, 2022

This PR is a general clean-up of our .gitignore files.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • git status should not report modifications in the source tree after building and testing

@fbergkemper fbergkemper self-assigned this Feb 9, 2022
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:
*~
*.slo
*.lo
*.o
*.pyc
*.swp
*.so
*.dylib
*.lai
*.la
*.a
autoconf/config.log
tags
cscope.out
*/Testing*/

So maybe we want a general cleanup? I also noticed we have 16 different .gitignore files. Maybe we can also try to improve the rest of the overall situation, because it seems like there are a lot of old and unneccessary ignores.

@fbergkemper
Copy link
Contributor Author

What about: *~ *.slo *.lo *.o *.pyc *.swp *.so *.dylib *.lai *.la *.a autoconf/config.log tags cscope.out */Testing*/

So maybe we want a general cleanup? I also noticed we have 16 different .gitignore files. Maybe we can also try to improve the rest of the overall situation, because it seems like there are a lot of old and unneccessary ignores.

Good point, I'd fully agree on a general clean-up.

@fbergkemper fbergkemper changed the title Update .gitignore cleanup .gitignore files Feb 9, 2022
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/gitignore-update branch from 1189264 to 64e0c8f Compare February 9, 2022 19:38
@fbergkemper fbergkemper marked this pull request as draft February 9, 2022 19:41
@fbergkemper fbergkemper removed the request for review from pstorz February 9, 2022 19:46
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/gitignore-update branch from 64e0c8f to 1e15ca3 Compare February 9, 2022 19:49
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/gitignore-update branch 3 times, most recently from 7dbcad6 to 8da0376 Compare February 21, 2022 16:15
@fbergkemper fbergkemper marked this pull request as ready for review February 21, 2022 16:59
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/gitignore-update branch from f3fb7bd to b120b66 Compare March 2, 2022 11:56
fbergkemper and others added 4 commits March 2, 2022 12:59
- remove development environment specific entries
- remove old relicts and unnecessary entries
- remove duplicates and unused entries
- sort alphabetically
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/gitignore-update branch from b120b66 to b46b9bb Compare March 2, 2022 11:59
The data directory was unused and implicitly removed by removing its
.gitignore, so we cannot install it anymore.
Also remove it from .gitignore.
@arogge arogge merged commit 9064271 into master Mar 2, 2022
@arogge arogge deleted the dev/fbergkemper/master/gitignore-update branch March 2, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants