Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: analytics module: show stored data per jobname in treemap #1082

Merged
merged 9 commits into from
Mar 11, 2022
Merged

webui: analytics module: show stored data per jobname in treemap #1082

merged 9 commits into from
Mar 11, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Feb 23, 2022

This PR introduces an analytics module into webui. The first feature of this new module
is a visualization of stored backup job data in a treemap.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@fbergkemper fbergkemper self-assigned this Feb 23, 2022
@fbergkemper fbergkemper marked this pull request as ready for review March 3, 2022 12:11
@pstorz pstorz changed the title webui: introduce analytics module webui: analytics module: show stored data per jobname in treemap Mar 10, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

  • Do we want/need to have some docs about the new analytics module?
  • The CHANGELOG.md commit is missing.

@fbergkemper
Copy link
Contributor Author

Good work.

* Do we want/need to have some docs about the new analytics module?

I don't think so, because the treemap is actually self-explanatory for users.

* The CHANGELOG.md commit is missing.

I'll add it after rebase and solving merge conflicts due to some pending PRs that will be merged first, I guess.

@fbergkemper
Copy link
Contributor Author

fbergkemper commented Mar 10, 2022

After a second thought and look about docs, we should add the new module here https://docs.bareos.org/IntroductionAndTutorial/BareosWebui.html#command-acl-requirements due to command.csv changes.

Going to add an extra commit for that.

@pstorz pstorz self-requested a review March 11, 2022 09:28
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit eda7cdd into bareos:master Mar 11, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/analytics branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants