Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: add pool column to volume lists #1120

Merged
merged 3 commits into from
Mar 14, 2022
Merged

webui: add pool column to volume lists #1120

merged 3 commits into from
Mar 14, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Mar 11, 2022

Volume listings should provide a pool column that shows to which pool a volume belongs to.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@fbergkemper fbergkemper self-assigned this Mar 11, 2022
@fbergkemper fbergkemper requested a review from pstorz March 11, 2022 14:30
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Works very well. Only the CHANGELOG.md looks suspicious.

CHANGELOG.md Outdated Show resolved Hide resolved
@pstorz pstorz merged commit f91caad into bareos:master Mar 14, 2022
bruno-at-bareos pushed a commit to bruno-at-bareos/bareos that referenced this pull request Mar 15, 2022
webui: add pool column to volume lists
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/s4862 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants