Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: fix restore file tree rendering #1127

Merged
merged 3 commits into from
Mar 16, 2022
Merged

webui: fix restore file tree rendering #1127

merged 3 commits into from
Mar 16, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Mar 16, 2022 •
edited by pstorz
Loading

Do not set a fixed height on the outer container, it leads to a miscalculated tree height
on the inner container and the tree not rendering properly.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted

@fbergkemper fbergkemper self-assigned this Mar 16, 2022
@fbergkemper fbergkemper requested a review from pstorz March 16, 2022 10:43
@fbergkemper fbergkemper mentioned this pull request Mar 16, 2022
Merged
13 tasks
pstorz
pstorz approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

@pstorz pstorz merged commit e4d0350 into bareos:master Mar 16, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/s5111 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@fbergkemper fbergkemper

Labels
requires backport to 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbergkemper @pstorz