Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats: include only jobtypes in list jobtotals that write data to volumes #1135

Merged
merged 2 commits into from
Mar 23, 2022
Merged

cats: include only jobtypes in list jobtotals that write data to volumes #1135

merged 2 commits into from
Mar 23, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Mar 22, 2022

The list jobtotals command should only summarize jobs
that have actually written to a storage.

These are the jobtypes B, A, a and C. Other jobtypes
like O and R should be excluded from jobtotals.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says that certain job types are excluded, but in fact only certain job types are included if I look at the code. The suggested title is in the CHANGELOG.md change suggestion.

core/src/cats/sql_list.cc Show resolved Hide resolved
core/src/cats/sql_list.cc Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fbergkemper fbergkemper changed the title cats: exclude certain jobtypes from list jobtotals cats: include only jobtypes in list jobtotals that write data to volumes Mar 22, 2022
@fbergkemper fbergkemper requested a review from pstorz March 22, 2022 15:18
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

…lumes

The list jobtotals command should only summarize jobs
that have actually written to a storage.

These are the jobtypes B, A, a and C. Other jobtypes
like O and R should be excluded from jobtotals.
@pstorz pstorz merged commit 2647f86 into bareos:master Mar 23, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/s5114 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants