Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome #1140

Merged
merged 2 commits into from
Mar 29, 2022
Merged

jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome #1140

merged 2 commits into from
Mar 29, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Mar 25, 2022

Starting in Chrome 101, the amount of information available in the
User Agent string will be reduced.

This PR removes the specific handling of IE < 8, to avoid issues
in Chrome >= 101.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title should contain the reason why we remove that support..

Why not simply remove the code in question without extra comment?
E8 is alread 13 years old and only running on OS that are not supported anymore.

CHANGELOG.md Outdated Show resolved Hide resolved
@fbergkemper fbergkemper changed the title jstreegrid: remove handling of IE < 8 using navigator interface jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome Mar 25, 2022
@fbergkemper
Copy link
Contributor Author

Why not simply remove the code in question without extra comment? E8 is alread 13 years old and only running on OS that are not supported anymore.

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

@pstorz
Copy link
Member

pstorz commented Mar 25, 2022

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

But that is what git is for, isn't it?

@fbergkemper
Copy link
Contributor Author

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

But that is what git is for, isn't it?

I'd like to have a clear hint, but I'm going to remove the code section.
It's not worth a discussion, let's get this done.

Starting in Chrome 101, the amount of information available in the
User Agent string will be reduced.

This PR removes the specific handling of IE < 8, to avoid issues
in Chrome >= 101.
@fbergkemper fbergkemper requested a review from pstorz March 25, 2022 14:09
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit fd4e2bc into bareos:master Mar 29, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/s5113 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants