-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome #1140
jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome #1140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title should contain the reason why we remove that support..
Why not simply remove the code in question without extra comment?
E8 is alread 13 years old and only running on OS that are not supported anymore.
It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident. |
But that is what git is for, isn't it? |
I'd like to have a clear hint, but I'm going to remove the code section. |
Starting in Chrome 101, the amount of information available in the User Agent string will be reduced. This PR removes the specific handling of IE < 8, to avoid issues in Chrome >= 101.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Starting in Chrome 101, the amount of information available in the
User Agent string will be reduced.
This PR removes the specific handling of IE < 8, to avoid issues
in Chrome >= 101.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testing