Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtest: fix always-incremental-consolidate sporadic failures #1154

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 11, 2022

Description

This PR fixes ai-consolidate-ignore-duplicate-job failing sporadically on different systems by adding a small delay
between test job runs. The test is also renamed to always-incremental-consolidate

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch 2 times, most recently from 0704453 to f7c0fcc Compare April 11, 2022 10:49
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remarks

systemtests/tests/CMakeLists.txt Show resolved Hide resolved
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch from f7c0fcc to ff1b3dd Compare April 11, 2022 12:36
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch from ff1b3dd to 78a4832 Compare April 11, 2022 13:22
@bruno-at-bareos bruno-at-bareos changed the title systemtest: fix ai-consolidate sporadic fails systemtest: fix always-incremental-consolidate sporadic failures Apr 14, 2022
@bruno-at-bareos bruno-at-bareos self-assigned this Apr 14, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch from 4bbe260 to 92d59cd Compare April 14, 2022 12:02
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything build fine locally and all checks have been done.

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving last changes.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch from 60f2797 to 33532e1 Compare April 20, 2022 08:15
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5130-fix-ai-consolidated-test-sporadic-fails branch from 33532e1 to 9cd7f6f Compare April 21, 2022 09:32
@pstorz pstorz merged commit 5b7f8bc into bareos:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants