bconsole: remove repeated successive entries from history. #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaaeddineelamri
changed the title
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
3 times, most recently
from
540adec
to
16de363
Compare
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
2 times, most recently
from
b5786a8
to
7637188
Compare
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
from
7637188
to
180d4c8
Compare
pstorz
force-pushed
the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
from
180d4c8
to
fee9100
Compare
pstorz
requested changes
Jun 13, 2022
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
from
fee9100
to
fda08ba
Compare
pstorz
deleted the
dev/alaaeddineelamri/master/bconsole-history-repeated-lines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
bconsole, when you type a command multiple times in a row, all these entries are saved in the history and make previous command navigation annoying.Example: you do
run job=xxx <a lot of arguments> yesand want to monitor the stats of the job, so you start typingstatus storageevery now and then to see how the job is behaving. Now you want to rerun the same job with the samerun job=xxx <a lot of arguments> yescommand, but it is buried behind multiplestatus storagecommands, and you would have to either press the arrow button up as many times as you entered thestatus storagecommand, or have to do a search. This PR changes the behavior by making sure multiple same commands in a row are only saved once.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing