Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats: make bvfs_update take archive jobs into consideration #1164

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 20, 2022

Description

Backport of PR #1152

When using .bvfs_update in bconsole, Virtual Full Archive jobs are not taken in consideration, and thus their paths are not updated and cannot be restored as a consequence. This PR makes sure .bvfs_update takes into consideration archive jobs when running.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that backporting test will not be done due to other changes in master

@alaaeddineelamri alaaeddineelamri changed the title Cats: make bvfs_update take archive jobs into consideration #1152 Cats: make bvfs_update take archive jobs into consideration Apr 20, 2022
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport, the CHANGELOG was missing a blank line see proposal.
I'm also missing the backport of the systemtest.

CHANGELOG.md Show resolved Hide resolved
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/bareos-21/s5098-bvfs-archive branch from 78aa9fb to 596814c Compare April 20, 2022 14:40
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now ready for merge

@pstorz pstorz merged commit 4e95a24 into bareos:bareos-21 Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants