-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dird: bconsole: add support for comma separated jobstatus values in list jobs command #1169
dird: bconsole: add support for comma separated jobstatus values in list jobs command #1169
Conversation
f655468
to
7574202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort, good work!
The PR is failing on FreeBSD, so take a look at that, something to do with the unordered_map
Make sure you run bareos-check-sources
as it reports a few missing things
7574202
to
4e8c3d8
Compare
4e8c3d8
to
551c5a8
Compare
6cfb8e7
to
fa14542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me
fa14542
to
ec46887
Compare
ec46887
to
c7db51a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well.
Description:
Changed the list jobs command to accept multiple values for jobstatus argument instead of one
exp : list jobs jobstatus=terminated,E,f
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testingTests