Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dird: bconsole: add support for comma separated jobstatus values in list jobs command #1169

Conversation

HediBenFraj
Copy link
Contributor

@HediBenFraj HediBenFraj commented Apr 21, 2022

Description:

Changed the list jobs command to accept multiple values for jobstatus argument instead of one
exp : list jobs jobstatus=terminated,E,f

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@HediBenFraj HediBenFraj changed the title dird: bconsole: added support for commas separated jobstatus value in list jobs command dird: bconsole: added support for commas separated jobstatus values in list jobs command Apr 21, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch from f655468 to 7574202 Compare April 21, 2022 16:23
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort, good work!

The PR is failing on FreeBSD, so take a look at that, something to do with the unordered_map
Make sure you run bareos-check-sources as it reports a few missing things

core/src/dird/ua_output.cc Outdated Show resolved Hide resolved
core/src/tests/select_functions.cc Outdated Show resolved Hide resolved
core/src/tests/select_functions.cc Outdated Show resolved Hide resolved
systemtests/tests/python-bareos/test_list_command.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/tests/select_functions.cc Outdated Show resolved Hide resolved
core/src/tests/select_functions.cc Outdated Show resolved Hide resolved
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch from 7574202 to 4e8c3d8 Compare April 26, 2022 16:54
core/src/dird/ua_select.cc Show resolved Hide resolved
core/src/tests/select_functions.cc Outdated Show resolved Hide resolved
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch from 4e8c3d8 to 551c5a8 Compare April 27, 2022 10:25
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch 2 times, most recently from 6cfb8e7 to fa14542 Compare April 28, 2022 12:37
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@pstorz pstorz requested a review from fbergkemper May 2, 2022 08:37
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch from fa14542 to ec46887 Compare May 3, 2022 09:31
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/extends-listjobs-jobstatus-multiple-values branch from ec46887 to c7db51a Compare May 3, 2022 15:18
@fbergkemper fbergkemper changed the title dird: bconsole: added support for commas separated jobstatus values in list jobs command dird: bconsole: add support for comma separated jobstatus values in list jobs command May 4, 2022
Copy link
Contributor

@fbergkemper fbergkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@fbergkemper fbergkemper assigned pstorz and unassigned fbergkemper May 4, 2022
@pstorz pstorz merged commit 858268c into bareos:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants